Add quantized cmake option back to fix build-apple-framework#3115
Closed
larryliu0820 wants to merge 1 commit intomainfrom
Closed
Add quantized cmake option back to fix build-apple-framework#3115larryliu0820 wants to merge 1 commit intomainfrom
larryliu0820 wants to merge 1 commit intomainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3115
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit dc9b3b3 with merge base 910f851 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
shoumikhin
approved these changes
Apr 18, 2024
Summary: As titled. Got too excited in #3062 and removed `EXECUTORCH_BUILD_QUANTIZED`. Looking at the CI job failure of `build-apple-framework` probably worth adding it back. Test Plan: See that CI job pass Reviewed By: shoumikhin Differential Revision: D56281923 Pulled By: larryliu0820
facebook-github-bot
force-pushed
the
fix-build-apple
branch
from
36a2605 to
dc9b3b3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56281923 |
Contributor
|
@larryliu0820 merged this pull request in eb47c4e. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: As titled. Got too excited in #3062 and removed
EXECUTORCH_BUILD_QUANTIZED. Looking at the CI job failure ofbuild-apple-frameworkprobably worth adding it back.Test Plan: See that CI job pass
Reviewers:
Subscribers:
Tasks:
Tags: